Conversation
thomas-zahner
force-pushed
the
file-preprocessing
branch
7 times, most recently
from
c5702b7 to
5bfd74e
Compare
thomas-zahner
force-pushed
the
file-preprocessing
branch
from
5bfd74e to
490e99a
Compare
thomas-zahner
force-pushed
the
file-preprocessing
branch
4 times, most recently
from
9bc1f12 to
538f721
Compare
thomas-zahner
force-pushed
the
file-preprocessing
branch
from
538f721 to
eb44275
Compare
thomas-zahner
force-pushed
the
file-preprocessing
branch
from
9306139 to
209c7aa
Compare
|
I've now worked around the regex size error that occurs on all new PRs. In the process I greatly simplified the link checking. (see last 3 commits) I'm now simply checking all links instead of only the new ones. As we seem to use a pretty fast link checker this seems to be no problem and the step completes in ~5 seconds. 🙃 So I see no good reason to stick to this overly complicated approach of only checking additions.Also I noticed that the src directory wasn't checked previously. In total the workflow should be faster because we have much fewer steps and we don't build twice. |
mre
left a comment
mre
left a comment
There was a problem hiding this comment.
Wow, this is really high quality work. You managed to significantly simplify the workflow. Good job! Also, thanks for following the boyscout rule and cleaning up the ignore file.
|
As a side note, I'm amazed at how fast lychee is. 5 seconds for the link check is amazing. Most of it is thanks to Rust and its ecosystem, of course. And fast servers. |
2 participants
Document the new preprocessor feature.
Ideally, we should only merge this with the next lychee release to prevent confusion by users.